Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

fix non_constant_identifier_names pattern field over-reporting #4300

Merged
merged 3 commits into from
Apr 21, 2023
Merged

fix non_constant_identifier_names pattern field over-reporting #4300

merged 3 commits into from
Apr 21, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 21, 2023

@github-actions github-actions bot added the linter-set-core Affects a rule in the core Dart rule set label Apr 21, 2023
@coveralls
Copy link

coveralls commented Apr 21, 2023 •
edited
Loading

Coverage Status

Coverage: 96.475% (+0.0008%) from 96.475% when pulling 6f39c8a on non_constant_identifier_names_fieldFP into 7050946 on main.

@pq pq merged commit e36813b into main Apr 21, 2023
@pq pq deleted the non_constant_identifier_names_fieldFP branch April 21, 2023 20:14
@pq pq mentioned this pull request Apr 26, 2023
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
fix non_constant_identifier_names pattern field over-reporting (dar…
2b3bf20 
…t-archive/linter#4300)

* fix `non_constant_identifier_names` pattern field over-reporting

* ++

* sort
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
linter-set-core Affects a rule in the core Dart rule set
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non_constant_identifier_names false positives for pattern fields
3 participants
@pq @coveralls @bwilkerson